fix: pass user-defined http(s) agent to websocket methods #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
===========================================
- Coverage 78.57% 64.28% -14.29%
===========================================
Files 2 2
Lines 14 14
Branches 3 3
===========================================
- Hits 11 9 -2
- Misses 3 4 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
dpopp07
force-pushed
the
support-agent-websocket
branch
2 times, most recently
from
efc4954
to
2617f4c
Compare
| const socket = (this.socket = new w3cWebSocket( | ||
| url, | ||
| null, | ||
| null, | ||
| options.headers, | ||
| null, | ||
| requestOptions, |
There was a problem hiding this comment.
I guess the change here is based on https://github.com/theturtle32/WebSocket-Node/blob/master/docs/WebSocketClient.md#connect-using-a-proxy-server
There was a problem hiding this comment.
Yep, that's correct!
germanattanasio
approved these changes
Sep 19, 2019
dpopp07
force-pushed
the
support-agent-websocket
branch
from
2617f4c
to
cbb0cef
Compare
dpopp07
force-pushed
the
support-agent-websocket
branch
from
cbb0cef
to
2840d71
Compare
watson-github-bot
pushed a commit
that referenced
this pull request
Sep 19, 2019
## [4.5.1](v4.5.0...v4.5.1) (2019-09-19) ### Bug Fixes * pass user-defined http(s) agent to websocket methods ([#953](#953)) ([4f1679c](4f1679c))
|
🎉 This PR is included in version 4.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accept
axiosoptions in the constructor to give the user extended control over their requests but we didn't translate this control over to the WebSocket requests. This PR doesn't give complete control over the WebSocket configuration but it allows the use of custom "agents" which will allow users to use WebSockets behind corporate proxies (an established use case).